Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table expandable row header has no top left border radius #39781

Merged
merged 2 commits into from Dec 24, 2022
Merged

fix: table expandable row header has no top left border radius #39781

merged 2 commits into from Dec 24, 2022

Conversation

chunsch
Copy link
Contributor

@chunsch chunsch commented Dec 24, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #39769

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English table expandable row header has no top left border radius
🇨🇳 Chinese Table 可扩展行标题没有左上边框半径

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2022 •
edited

@codecov
Copy link

codecov bot commented Dec 24, 2022 •
edited

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (8d30d02) compared to base (189f912).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #39781   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          556       556           
  Lines         9624      9624           
  Branches      2722      2722           
=========================================
  Hits          9624      9624
Impacted Files Coverage Δ
components/table/style/radius.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 056dabc into ant-design:master Dec 24, 2022
@chunsch chunsch deleted the fix-table-radius branch December 24, 2022 07:37
foryuki pushed a commit to foryuki/ant-design that referenced this pull request Dec 24, 2022
@chunsch
fix: table expandable row header has no top left border radius (ant-d…
9d671ed 
…esign#39781)

* fix: expandable row table header is rendered as td and has no top left border radius ant-design#39769

* test: update expandIconColumnIndex
@vagusX vagusX mentioned this pull request Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

@yoyo837 yoyo837 yoyo837 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table -> Expandable row table header is rendered as td and has no top left border radius
3 participants
@chunsch @afc163 @yoyo837