Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): reset aria-label in table column #39738

Merged
merged 2 commits into from Dec 22, 2022

Conversation

kiner-tang
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #39410

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English reset aria-label in table column
🇨🇳 Chinese 重置表格列的aria-label属性值

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (a52336a) compared to base (78592a5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39738   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          556       556           
  Lines         9607      9624   +17     
  Branches      2718      2722    +4     
=========================================
+ Hits          9607      9624   +17     
Impacted Files Coverage Δ
components/table/hooks/useSorter.tsx 100.00% <100.00%> (ø)
components/_util/responsiveObserve.ts
components/_util/responsiveObserver.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit b91bab0 into ant-design:master Dec 22, 2022
@vagusX vagusX mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table column aria-label implementation creates a poor screen reader experience
2 participants