Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table border issue #39729

Merged
merged 6 commits into from Dec 22, 2022
Merged

fix: table border issue #39729

merged 6 commits into from Dec 22, 2022

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Dec 22, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #38724
close #39677
close #39728
close #38735

💡 Background and solution

顺便把 border 改成实色,解决一下重叠之后颜色加深的问题

📝 Changelog

Language Changelog
🇺🇸 English Fix Table missing border-bottom in merged cell and unexpected border color if overlapping。
🇨🇳 Chinese 修复 Table 组件合并单元格后底部边框消失和边框重叠时颜色变深的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

size-limit report 📦

Path Size
./dist/antd.min.js 377.6 KB (+39 B 🔺)
./dist/antd-with-locales.min.js 432.89 KB (+38 B 🔺)

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (0382a6b) compared to base (6236e35).
Patch has no changes to coverable lines.

❗ Current head 0382a6b differs from pull request most recent head 89fa240. Consider uploading reports for the commit 89fa240 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39729   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          556       556           
  Lines         9625      9625           
  Branches      2722      2722           
=========================================
  Hits          9625      9625           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Dec 22, 2022

@MadCcc
Copy link
Member Author

MadCcc commented Dec 22, 2022

之前的 border 时透明色,暗色主题下就是白色带透明度,所以白底上看不出来。实际应该是 table 的 border radius 问题。

@MadCcc
Copy link
Member Author

MadCcc commented Dec 22, 2022

@MadCcc
Copy link
Member Author

MadCcc commented Dec 22, 2022

argos 响应有点慢

@afc163
Copy link
Member

afc163 commented Dec 22, 2022

顺便把 border 改成实色,解决一下重叠之后颜色加深的问题

changelog 也写一下。

@MadCcc
Copy link
Member Author

MadCcc commented Dec 22, 2022

顺便把 border 改成实色,解决一下重叠之后颜色加深的问题

changelog 也写一下。

Done.

@MadCcc MadCcc merged commit 3307a8b into master Dec 22, 2022
@MadCcc MadCcc deleted the fix/table-border branch December 22, 2022 08:03
@vagusX vagusX mentioned this pull request Dec 26, 2022
@afc163
Copy link
Member

afc163 commented Dec 26, 2022

图片

这个会造成筛选表格时 border 的 transition 效果出现黑条。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

表格行列合并后,合并行的边框缺失 table 合并列样式错误(最后一行缺少border)
3 participants