Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Table header radius when has fixed header and columns #39723

Merged
merged 1 commit into from Dec 22, 2022

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 22, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #39115 (comment)

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table header radius missing when has fixed header and columns.
🇨🇳 Chinese 修复 Table 列头的圆角丢失问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

size-limit report 📦

Path Size
./dist/antd.min.js 377.56 KB (+5 B 🔺)
./dist/antd-with-locales.min.js 432.85 KB (+5 B 🔺)

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b82d9d3) compared to base (8c61261).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39723   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          556       556           
  Lines         9625      9625           
  Branches      2722      2722           
=========================================
  Hits          9625      9625           
Impacted Files Coverage Δ
components/table/style/radius.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc
Copy link
Member

MadCcc commented Dec 22, 2022

这个是里面滚动的 header 漏出来了吧

@afc163
Copy link
Member Author

afc163 commented Dec 22, 2022

这个是里面滚动的 header 漏出来了吧

是的。

@MadCcc
Copy link
Member

MadCcc commented Dec 22, 2022

image
这样改好像没用,昨天试了一下可能只有 overflow 可以解

@afc163
Copy link
Member Author

afc163 commented Dec 22, 2022

图片

这个 dom 上本来就有 overflow: hidden,少个 radius。

@afc163
Copy link
Member Author

afc163 commented Dec 22, 2022

@afc163 afc163 changed the title style: fix Table header radius when has fixed columns style: fix Table header radius when has fixed header and columns Dec 22, 2022
@MadCcc
Copy link
Member

MadCcc commented Dec 22, 2022

https://ant.design/components/table-cn#components-table-demo-fixed-columns-header 这个例子的修了。

这个例子好像还是有问题

@afc163
Copy link
Member Author

afc163 commented Dec 22, 2022

确实。

@afc163
Copy link
Member Author

afc163 commented Dec 22, 2022

现在好了

@afc163
Copy link
Member Author

afc163 commented Dec 22, 2022

来个 +1

@afc163 afc163 merged commit 0e98cb5 into master Dec 22, 2022
@afc163 afc163 deleted the style/table-radius branch December 22, 2022 08:51
@vagusX vagusX mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table 固定列,表格无数据时,右侧边框不显示
3 participants