New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[Wave]: CC => FC #39705
refactor[Wave]: CC => FC #39705
Conversation
size-limit report 📦
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #39705 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 557 561 +4
Lines 9621 9637 +16
Branches 2722 2736 +14
=========================================
+ Hits 9621 9637 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
删了几个 case,cov 果然掉了…… |
原则上不删已有的 case,特别是重构 |
|
* fix * refactor[Wave]: CC => FC * fix lint * fix * fix * fix * add test case * add test case * fix test * fix test * test case * add test case * fix * fix * fix * fix * raname * fix * test case * test case * test case * fix test * test case * refactor: Use React way * test: coverage * chore: clean up * rerun fail ci * fix: React 17 error * test: fix test case * test: fix test case * fix borderRadius * test: fix test case * chore: clean up * chore: clean up Co-authored-by: 二货机器人 <smith3816@gmail.com>
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Use more react way which support multiple wave motion:
📝 Changelog
将 Wave 重构为 Function Component
删除了通过 forwardRef 转发 ref,因为这个只在 test case 中用到了,在实际代码中是无用的
删除了test case 中关于 class 静态属性的测试用例,在 FC 中没办法获取到组件内部的属性
☑️ Self-Check before Merge