Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): fix justify and align properties are not reactive for Row #39704

Merged
merged 1 commit into from Dec 21, 2022

Conversation

candy4290
Copy link
Contributor

@candy4290 candy4290 commented Dec 21, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #39690

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix justify and align properties are not reactive for Row
🇨🇳 Chinese 修复Row组件justify和align属性,动态改变不生效的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

Copy link
Contributor Author

@candy4290 candy4290 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix justify and align properties are not reactive for Row

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (caeb252) compared to base (a692dc1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39704   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          556       556           
  Lines         9605      9607    +2     
  Branches      2717      2718    +1     
=========================================
+ Hits          9605      9607    +2     
Impacted Files Coverage Δ
components/grid/row.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit e5c60c8 into ant-design:master Dec 21, 2022
@candy4290
Copy link
Contributor Author

candy4290 commented Dec 21, 2022

4.x has the same question, here is the pr: #39706
Reproduction link: https://codesandbox.io/s/ji-ben-shi-yong-antd-4-24-5-forked-x0i7bh?file=/demo.js

@candy4290 candy4290 deleted the cxx/39690 branch December 21, 2022 07:25
@vagusX vagusX mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Justify and align properties are not reactive for Row
2 participants