Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade rc-table for a11y issue #39700

Merged
merged 2 commits into from Dec 21, 2022
Merged

fix: upgrade rc-table for a11y issue #39700

merged 2 commits into from Dec 21, 2022

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 21, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

react-component/table#855

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Improve Table a11y by appling aria-props to table element.
🇨🇳 Chinese 修正 Table aria-* 属性到 table 元素上以支持更好的可访问性。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 21, 2022

单改这个是要发patch吗?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

size-limit report 📦

Path Size
./dist/antd.min.js 377.4 KB
./dist/antd-with-locales.min.js 432.71 KB

@afc163
Copy link
Member Author

afc163 commented Dec 21, 2022

看看有没有 snapshot 变化

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (765353d) compared to base (d93bca1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39700   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          556       556           
  Lines         9605      9605           
  Branches      2717      2717           
=========================================
  Hits          9605      9605           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit b5f27c8 into master Dec 21, 2022
@zombieJ zombieJ deleted the fix/table-a11y branch December 21, 2022 06:01
@vagusX vagusX mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants