fix: Tabs inkBar in StrictMode #39653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
li-jia-nan
approved these changes
Dec 19, 2022
afc163
reviewed
Dec 19, 2022
| @@ -263,6 +267,7 @@ exports[`Tabs tabBarGutter should work 2`] = ` | |||
| > | |||
| <div | |||
| class="ant-tabs-tab ant-tabs-tab-active" | |||
| data-node-key="null" | |||
There was a problem hiding this comment.
像是个 bug，我瞅瞅
Update：发现是测试用例写的比较随便，没给 key。另外 data-node-key 是 querySelector 需要用，总是有的。
size-limit report 📦
|
github-actions
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #39653 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 546 546
Lines 9366 9366
Branches 2656 2656
=========================================
Hits 9366 9366 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
On the latest versions of Chrome the problem is fixed, but it seems that there is a problem for the older ones. I've tested with Chrome 45 (Ant 5.12) and the inkBar is missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #39631
fix #39494
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge