Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update icon color token in Select #39644

Merged
merged 1 commit into from Dec 19, 2022
Merged

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Dec 19, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #39618

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix wrong usage of icon color token in Select.
🇨🇳 Chinese 修复 Select 组件 icon 颜色使用的 token.

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2022

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 373.56 KB (+11 B 🔺)
./dist/antd-with-locales.min.js 427.02 KB (+11 B 🔺)

@@ -105,7 +105,7 @@ const genBaseStyle: GenerateStyle<CascaderToken> = (token) => {
'&:hover': {
background: token.controlItemBgHover,
},
' &-disabled': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种感觉应该直接用工具发现和报错。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

结果而言没啥影响,但是这个想要检查出来只能运行时分析了

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

反而 string 类型的 cssinjs 好做 lint

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (26ccbd6) compared to base (1ce7d3a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39644   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          546       546           
  Lines         9366      9366           
  Branches      2656      2656           
=========================================
  Hits          9366      9366           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc MadCcc merged commit 64edc6d into master Dec 19, 2022
@MadCcc MadCcc deleted the fix/control-icon-color branch December 19, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

colorTextDisabled 自定义颜色,导致其他非文字部分颜色改变
3 participants