Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table should not warn defaultProps #39571

Merged
merged 5 commits into from Dec 15, 2022

Conversation

chunsch
Copy link
Contributor

@chunsch chunsch commented Dec 15, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #39440

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table unexpected warning about DefaultProps.
🇨🇳 Chinese 修复 Table 组件关于 DefaultProps 的警告。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022

@chunsch chunsch changed the title fix: Table should not warn DefaultProps [WIP] fix: Table should not warn DefaultProps Dec 15, 2022
@chunsch chunsch changed the title [WIP] fix: Table should not warn DefaultProps fix: Table should not warn DefaultProps Dec 15, 2022
@yoyo837
Copy link
Contributor

yoyo837 commented Dec 15, 2022

/rebase

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 15, 2022

来个空提交, 触发一下

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (cf8abf6) compared to base (b04b759).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39571   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          546       546           
  Lines         9363      9362    -1     
  Branches      2653      2652    -1     
=========================================
- Hits          9363      9362    -1     
Impacted Files Coverage Δ
components/dropdown/dropdown-button.tsx 100.00% <ø> (ø)
components/modal/PurePanel.tsx 100.00% <ø> (ø)
components/popconfirm/PurePanel.tsx 100.00% <ø> (ø)
components/transfer/operation.tsx 100.00% <ø> (ø)
components/_util/ActionButton.tsx 100.00% <100.00%> (ø)
components/button/button.tsx 100.00% <100.00%> (ø)
components/modal/Modal.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chunsch
Copy link
Contributor Author

chunsch commented Dec 15, 2022

@yoyo837 嗯嗯,谢谢你。update snapshot 后看到可以了 : D

@zombieJ zombieJ merged commit 359eaa6 into ant-design:master Dec 15, 2022
@chunsch chunsch deleted the fix-table-warn branch December 15, 2022 13:07
Wxh16144 added a commit to Wxh16144-forks/ant-design that referenced this pull request Dec 15, 2022
* master:
  fix: Table should not warn DefaultProps (ant-design#39571)
  type: Button type optimization (ant-design#39533)
  docs: Add Form prefix demo (ant-design#39580)
  site: icon update (ant-design#39534)
  demo: update demo (ant-design#39576)
  fix: segmented icon margin (ant-design#39575)
  type: add FloatButtonGroupProps (ant-design#39553)
  fix: add img cdn link for site (ant-design#39554)
  docs: Tree conduction (ant-design#39566)
@chunsch chunsch changed the title fix: Table should not warn DefaultProps fix: table should not warn defaultProps Dec 17, 2022
@MadCcc MadCcc mentioned this pull request Dec 18, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants