Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ConfigProvider support select.showSearch #39531

Merged
merged 1 commit into from Dec 14, 2022

Conversation

YinDongFang
Copy link
Contributor

[English Template / 英文模板]

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

需求背景

项目中大部分Select组件无论是多选还是单选模式都需要支持搜索,单选模式默认不支持搜索,需要项目中每个Select手动添加,容易遗漏

实现

ConfigProvider增加select配置项支持showSearch字段

📝 更新日志

语言 更新描述
🇺🇸 英文 ConfigProvider support config select.showSearch
🇨🇳 中文 ConfigProvider支持配置select.showSearch

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022

@li-jia-nan
Copy link
Member

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (875e518) compared to base (ec76041).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #39531   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          557       557           
  Lines         9581      9581           
  Branches      2711      2711           
=========================================
  Hits          9581      9581           
Impacted Files Coverage Δ
components/config-provider/context.tsx 100.00% <ø> (ø)
components/config-provider/index.tsx 100.00% <ø> (ø)
components/select/index.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YinDongFang
Copy link
Contributor Author

和这个MR内容一样,只是处理了冲突。上个MR操作错误关闭了

@li-jia-nan li-jia-nan merged commit bcd3230 into ant-design:feature Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants