New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(antd/transfer): transfer performance optimization while dataSourc… #39465
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #39465 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 556 557 +1
Lines 9624 9638 +14
Branches 2722 2722
=========================================
+ Hits 9624 9638 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Could you provide a benchmark stats? |
snapshot diff failed. Rebase master pls. |
Hi @wqs576222103. Thanks for your contribution. The path |
3b21531
to
83e8329
Compare
83e8329
to
4faf47a
Compare
I will try it |
have already Rebased |
|
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Performance optimization for large data sources and long keys on antd/transfer
Hi all,
I've been looking into ways to improve the performance of ant/transfer when dealing with large data sources and long keys. I've implemented a few changes that have shown significant improvements in our benchmarks.
Here are the changes I made:
I've included some before and after benchmarks below to show the improvements.
Before:
After:
Here is a Chinese article about the debugging process when I encounter a problem. the UI looks like below.
The transfer component takes about more than ten seconds to check/uncheck or move a lot of data from left to right
You can see codesandbox online examples that checked/unchecked the root of tree or transfer left/right tooks much time.
There is a react project react-ant-transferTree-demo with modified ANTD source dist code.
Please let me know if you have any feedback or questions. I'd be happy to make any additional changes if needed.
Best,
wangqs
📝 Changelog
There
☑️ Self-Check before Merge