Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix tour step type #39382

Merged
merged 25 commits into from Dec 19, 2022
Merged

fix: Fix tour step type #39382

merged 25 commits into from Dec 19, 2022

Conversation

heiyu4585
Copy link
Contributor

@heiyu4585 heiyu4585 commented Dec 7, 2022 •
edited

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#39307

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix tourStep set type=‘primary’ not work
🇨🇳 Chinese 修复 TourStep 设置 type=‘primary’ 无效的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163
Copy link
Member

afc163 commented Dec 7, 2022

修复tour step type

看不太懂。

@afc163
Copy link
Member

afc163 commented Dec 7, 2022

来个 type.test.tsx 用例？

@MadCcc
Copy link
Member

MadCcc commented Dec 7, 2022

要补一下 step 单独传 type 的用例

@heiyu4585
Copy link
Contributor Author

heiyu4585 commented Dec 7, 2022 •
edited

来个 type.test.tsx 用例？
sorry,两位,我先占位.先过rc-tour的pr,

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022 •
edited

@codecov
Copy link

codecov bot commented Dec 12, 2022 •
edited

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (036c8aa) compared to base (1f5ab2d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #39382   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          546       546           
  Lines         9363      9366    +3     
  Branches      2653      2656    +3     
=========================================
+ Hits          9363      9366    +3
Impacted Files Coverage Δ
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <ø> (ø)
components/tour/index.tsx 100.00% <ø> (ø)
components/button/button.tsx 100.00% <100.00%> (ø)
components/tour/panelRender.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc
Copy link
Member

MadCcc commented Dec 12, 2022

semver 要改了

@MadCcc
Copy link
Member

MadCcc commented Dec 12, 2022

snapshot 整体应该不变吧

@MadCcc
Copy link
Member

MadCcc commented Dec 15, 2022

Test 还是挂的

@heiyu4585
Copy link
Contributor Author

heiyu4585 commented Dec 15, 2022 •
edited

Test 还是挂的

收到，等豆酱大佬跟进PureRender

li-jia-nan
li-jia-nan reviewed Dec 15, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@li-jia-nan
Copy link
Member

/rebase

@li-jia-nan
Copy link
Member

\rebase

@MadCcc MadCcc merged commit 1eaf125 into ant-design:master Dec 19, 2022
@afc163
Copy link
Member

afc163 commented Dec 19, 2022

changelog 按用户视角改改

@heiyu4585
Copy link
Contributor Author

changelog 按用户视角改改

done

@xrkffgg xrkffgg mentioned this pull request Dec 19, 2022
Merged
@heiyu4585 heiyu4585 deleted the fix-step-type branch December 22, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@yoyo837 yoyo837 yoyo837 left review comments

@li-jia-nan li-jia-nan li-jia-nan left review comments

@MadCcc MadCcc MadCcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@heiyu4585 @afc163 @MadCcc @li-jia-nan @yoyo837 @zombieJ