feat: Modal.xxx supports footer #39048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## feature #39048 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 548 548
Lines 9407 9409 +2
Branches 2675 2677 +2
=========================================
+ Hits 9407 9409 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
codeball-ai-writer
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
OK! I will try! |
afc163
reviewed
Dec 5, 2022
|
feature branch |
|
I changed branch |
afc163
reviewed
Dec 5, 2022
components/config-provider/__tests__/__snapshots__/components.test.tsx.snap
Outdated
Show resolved
Hide resolved
…n#38939) * feat: tour ts define update * test: add more unit test
…to feat/modal_footer
|
@afc163 Completed! |
afc163
reviewed
Dec 7, 2022
afc163
reviewed
Dec 7, 2022
afc163
approved these changes
Dec 7, 2022
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Modal func has not footer props. Therefore Modal footer created by modal func cannot be modified.
Finnaly I add footer props to Modal Func.
📝 Changelog
footernow.footer属性以自定义按钮列表。☑️ Self-Check before Merge