Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Anchor component changed to data-driven #39034

Merged
merged 8 commits into from Nov 30, 2022

Conversation

foryuki
Copy link
Contributor

@foryuki foryuki commented Nov 27, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add items prop to make configuration options content driven by data, and support nesting through children.
🇨🇳 Chinese 增加 items prop 数据化配置选项内容,支持通过 children 嵌套 。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2022

Copy link
Contributor

@abenhamdine abenhamdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could also be useful to add @deprecated tag on children property

components/anchor/Anchor.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (c9eb779) compared to base (30f7dcc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #39034   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          545       545           
  Lines         9361      9368    +7     
  Branches      2653      2658    +5     
=========================================
+ Hits          9361      9368    +7     
Impacted Files Coverage Δ
components/anchor/AnchorLink.tsx 100.00% <ø> (ø)
components/anchor/Anchor.tsx 100.00% <100.00%> (ø)
components/menu/index.tsx 100.00% <0.00%> (ø)
components/menu/SubMenu.tsx 100.00% <0.00%> (ø)
components/menu/MenuItem.tsx 100.00% <0.00%> (ø)
components/mentions/index.tsx 100.00% <0.00%> (ø)
components/menu/MenuDivider.tsx 100.00% <0.00%> (ø)
components/menu/OverrideContext.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@foryuki foryuki marked this pull request as ready for review November 29, 2022 14:44
@foryuki foryuki changed the base branch from master to feature November 30, 2022 01:54
@MadCcc MadCcc merged commit 51da7e3 into ant-design:feature Nov 30, 2022
heiyu4585 pushed a commit to heiyu4585/ant-design that referenced this pull request Dec 16, 2022
* feat: Anchor component changed to data-driven

* test: add test cases for data driven items

* fix: type

* chore: mark deprecated for anchor children prop

* docs: add items description

* test: update snapshot

* docs: demos changed to data-driven

* docs: Keep the old jsx syntax demo for debugging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants