Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): Sorted/Filtered table fixed column transparent background unreadable #39012

Merged
merged 6 commits into from Dec 28, 2022

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Nov 26, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #39006

💡 Background and solution

  • fix: Sorted/Filtered table fixed column transparent background unreadable

📝 Changelog

Language Changelog
🇺🇸 English fix Sorted/Filtered table fixed column transparent background unreadable
🇨🇳 Chinese 修复排序/筛选的表格的固定列背景色透明导致显示异常问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2022

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Base: 99.98% // Head: 100.00% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (82d02ff) compared to base (63819cb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #39012      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files         557       557              
  Lines        9620      9620              
  Branches     2722      2722              
===========================================
+ Hits         9619      9620       +1     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
components/config-provider/context.tsx
components/config-provider/cssVariables.tsx
components/config-provider/cssVariables.ts 100.00% <0.00%> (ø)
components/config-provider/context.ts 100.00% <0.00%> (ø)
components/tooltip/index.tsx 100.00% <0.00%> (+1.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Nov 27, 2022

随手看看 #38914

@kiner-tang
Copy link
Member Author

随手看看 #38914

好的,我看看

@afc163
Copy link
Member

afc163 commented Dec 3, 2022

ping ~

@afc163
Copy link
Member

afc163 commented Dec 7, 2022

@MadCcc 看看,尽快修复吧。

@MadCcc
Copy link
Member

MadCcc commented Dec 28, 2022

这个透明色应该是刻意的?

@MadCcc
Copy link
Member

MadCcc commented Dec 28, 2022

image
这个颜色不对了

components/table/style/index.tsx Outdated Show resolved Hide resolved
components/table/style/index.tsx Outdated Show resolved Hide resolved
@kiner-tang
Copy link
Member Author

@MadCcc 帮忙再看看

docs/react/recommendation.zh-CN.md Outdated Show resolved Hide resolved
components/table/style/index.tsx Outdated Show resolved Hide resolved
components/table/style/index.tsx Outdated Show resolved Hide resolved
kiner-tang and others added 2 commits December 28, 2022 15:43
@MadCcc MadCcc merged commit 4f35779 into ant-design:master Dec 28, 2022
@afc163
Copy link
Member

afc163 commented Dec 28, 2022

还有 #39860

yoyo837 pushed a commit that referenced this pull request Dec 31, 2022
… unreadable (#39012)

* fix: Sorted/Filtered table fixed column transparent background unreadable

* feat: remove redundant code

* Update components/table/style/index.tsx

Co-authored-by: MadCcc <1075746765@qq.com>

* feat: code optimize

* style: reset format doc

Co-authored-by: MadCcc <1075746765@qq.com>
@tonny008
Copy link

好像并没有修复啊,表格背景透明的情况,横向滚动固定列也会透出来后面的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorted/Filtered table fixed column transparent background unreadable
4 participants