feat: New Component QRCode #38948

li-jia-nan · 2022-11-24T07:32:23Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	feat: New Component Qr-Code
🇨🇳 Chinese	feat: 二维码组件

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

github-actions · 2022-11-24T07:32:36Z

github-actions · 2022-11-24T07:38:06Z

Size Change: +13.6 kB (+2%)

Total Size: 913 kB

Filename	Size	Change
`./dist/antd-with-locales.min.js`	485 kB	+6.89 kB (+1%)
`./dist/antd.min.js`	428 kB	+6.74 kB (+2%)

_{compressed-size-action}

codecov · 2022-11-24T08:22:15Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ace5d61) compared to base (e975e5d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           feature    #38948    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          546       548     +2     
  Lines         9515      9407   -108     
  Branches      2714      2675    -39     
==========================================
- Hits          9515      9407   -108

Impacted Files	Coverage Δ
components/anchor/AnchorLink.tsx	`100.00% <ø> (ø)`
components/locale-provider/index.tsx	`100.00% <ø> (ø)`
components/locale/en_US.tsx	`100.00% <ø> (ø)`
components/locale/zh_CN.tsx	`100.00% <ø> (ø)`
components/theme/themes/seed.ts	`100.00% <ø> (ø)`
components/theme/util/alias.ts	`100.00% <ø> (ø)`
components/tour/panelRender.tsx	`100.00% <ø> (ø)`
components/anchor/Anchor.tsx	`100.00% <100.00%> (ø)`
components/mentions/index.tsx	`100.00% <100.00%> (ø)`
components/menu/MenuDivider.tsx	`100.00% <100.00%> (ø)`
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

li-jia-nan · 2022-11-24T09:47:50Z

还差缩略图没换，随便找了个 svg，这个需要换一下

demo 中的 logo 也是随便找的 svg，需要换一下

MadCcc

话说看了下 wiki，二维码的英文实际上是 QR code，所以这个组件命名可能叫 QRCode 比较好，文件夹名也可以改一下

components/qr-code/demo/base.md

components/qr-code/demo/download.md

components/qr-code/demo/download.tsx

components/qr-code/index.en-US.md

components/qr-code/index.tsx

components/qr-code/style/index.ts

components/qr-code/interface.ts

li-jia-nan · 2022-11-24T15:09:39Z

话说看了下 wiki，二维码的英文实际上是 QR code，所以这个组件命名可能叫 QRCode 比较好，文件夹名也可以改一下

done

MadCcc · 2022-11-25T07:29:48Z

文件夹都小写，qrcode 吧

MadCcc · 2022-11-25T07:41:51Z

这个换成 antd 的 logo

MadCcc · 2022-11-25T07:42:17Z

多了一个 Title

li-jia-nan · 2022-11-25T10:13:22Z

文件夹都小写，qrcode 吧

done

li-jia-nan · 2022-11-25T10:13:32Z

这个换成 antd 的 logo

done

li-jia-nan · 2022-11-25T10:42:26Z

多了一个 Title

done

li-jia-nan · 2022-11-25T11:15:48Z

mac 改了文件夹名字大小写，推上去 git 不会识别的……神奇，晚上回家用 windows 改吧

* feat: QrCode * fix * fix * fix: fix bug * fix: fix bug * fix * fix * fix * delete * delete * test case * fix lint * bundlesize * demo * fix: fix test

Co-authored-by: MadCcc <1075746765@qq.com>

MadCcc · 2022-12-02T08:20:26Z

这个感觉可以换个长链接，用 QRCode 页的地址试试，最好每个都能有变化

components/qrcode/index.tsx

Co-authored-by: MadCcc <1075746765@qq.com>

li-jia-nan · 2022-12-02T08:57:18Z

这个感觉可以换个长链接，用 QRCode 页的地址试试，最好每个都能有变化

QRCode 页的地址也不够长，我换成 QRCode.React 官网那个例子了

components/mentions/index.en-US.md

components/qrcode/demo/errorlevel.tsx

li-jia-nan · 2022-12-05T06:16:31Z

🎉🎉🎉

* feat: qrcode * chore: code clean * feat: New Component Qr-Code (ant-design#38891) * feat: QrCode * fix * fix * fix: fix bug * fix: fix bug * fix * fix * fix * delete * delete * test case * fix lint * bundlesize * demo * fix: fix test * remove dep * update snap * en docs * refactor: rename tests dir * Update components/qr-code/demo/base.md Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qr-code/demo/base.md Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qr-code/demo/download.md Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qr-code/demo/download.md Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qr-code/demo/download.tsx Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qr-code/demo/logo.md Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qr-code/index.tsx Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qr-code/style/index.ts Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qr-code/style/index.ts Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qr-code/demo/logo.md Co-authored-by: MadCcc <1075746765@qq.com> * rename * fix * adjust text * rename * fix title * rename * rename * fix: snap * fix * bundlesize * update demo * update docs * add demo * add docs * add docs * test: add warning * update demo * bundlesize * update test case * update demo * feat: add onRefresh、add status * fix: fix demo * fix: fix demo * add locale * add locale * add test case * update snap * fix demo * update demo * update demo * update demo * Update components/qrcode/style/index.ts Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qrcode/style/index.ts Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qrcode/style/index.ts Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qrcode/style/index.ts Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qrcode/style/index.ts Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qrcode/interface.ts Co-authored-by: MadCcc <1075746765@qq.com> * Update components/qrcode/style/index.ts Co-authored-by: MadCcc <1075746765@qq.com> * fix * Update components/qrcode/index.tsx Co-authored-by: MadCcc <1075746765@qq.com> * fix * fix * fix * add decs * fix * fix * fix type * fix * fix demo * fix lint * fix lint * add test case for bordered * prettier-ignore Co-authored-by: MadCcc <1075746765@qq.com> Co-authored-by: 栗嘉男 <lijianan@lijianandeMacBook-Pro.local>

li-jia-nan marked this pull request as ready for review November 24, 2022 07:32

github-actions bot added the codeball:needs-careful-review label Nov 24, 2022

li-jia-nan changed the title ~~feat: New Component Qr-Code~~ [WIP] feat: New Component Qr-Code Nov 24, 2022

li-jia-nan requested a review from MadCcc November 24, 2022 08:48

li-jia-nan changed the title ~~[WIP] feat: New Component Qr-Code~~ feat: New Component Qr-Code Nov 24, 2022

li-jia-nan requested review from zombieJ and afc163 November 24, 2022 11:15

MadCcc reviewed Nov 24, 2022

View reviewed changes

li-jia-nan requested a review from MadCcc November 24, 2022 15:11

MadCcc and others added 9 commits November 25, 2022 23:19

feat: qrcode

16e05ac

chore: code clean

c3b8b44

feat: New Component Qr-Code (#38891)

a974d94

* feat: QrCode * fix * fix * fix: fix bug * fix: fix bug * fix * fix * fix * delete * delete * test case * fix lint * bundlesize * demo * fix: fix test

remove dep

fe85505

update snap

581273f

en docs

df04184

refactor: rename tests dir

93e7ae7

Update components/qr-code/demo/base.md

60ad00a

Co-authored-by: MadCcc <1075746765@qq.com>

Update components/qr-code/demo/base.md

2d391b5

Co-authored-by: MadCcc <1075746765@qq.com>

fix

01983d6

MadCcc reviewed Dec 2, 2022

View reviewed changes

components/qrcode/index.tsx Outdated Show resolved Hide resolved

li-jia-nan and others added 4 commits December 2, 2022 16:37

resolve conflicts

6ae571c

Update components/qrcode/index.tsx

0995bea

Co-authored-by: MadCcc <1075746765@qq.com>

fix

865416b

fix

7c630f7

li-jia-nan added 4 commits December 2, 2022 17:39

fix

0618809

fix

5373f44

add decs

0f952fd

fix

8c4e484

li-jia-nan requested a review from MadCcc December 2, 2022 13:30

li-jia-nan added 7 commits December 2, 2022 21:33

fix

6ea3df3

fix type

799ce52

fix

009c0d2

fix demo

bb05a8e

fix lint

c86712a

fix lint

2b9fc58

add test case for bordered

0bb9d45

MadCcc reviewed Dec 5, 2022

View reviewed changes

components/mentions/index.en-US.md Show resolved Hide resolved

components/qrcode/demo/errorlevel.tsx Outdated Show resolved Hide resolved

prettier-ignore

bbc94a3

li-jia-nan requested a review from MadCcc December 5, 2022 03:03

fix

ace5d61

MadCcc approved these changes Dec 5, 2022

View reviewed changes

MadCcc merged commit 240210a into feature Dec 5, 2022

MadCcc deleted the feat/QrCode branch December 5, 2022 06:15

xrkffgg mentioned this pull request Dec 19, 2022

docs: add 5.1.0 changelog #39667

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: New Component QRCode #38948

feat: New Component QRCode #38948

li-jia-nan commented Nov 24, 2022 •

edited

github-actions bot commented Nov 24, 2022 •

edited

github-actions bot commented Nov 24, 2022 •

edited

codecov bot commented Nov 24, 2022 •

edited

li-jia-nan commented Nov 24, 2022

MadCcc left a comment

li-jia-nan commented Nov 24, 2022

MadCcc commented Nov 25, 2022

MadCcc commented Nov 25, 2022 •

edited

MadCcc commented Nov 25, 2022

li-jia-nan commented Nov 25, 2022

li-jia-nan commented Nov 25, 2022 •

edited

li-jia-nan commented Nov 25, 2022

li-jia-nan commented Nov 25, 2022 •

edited

MadCcc commented Dec 2, 2022

li-jia-nan commented Dec 2, 2022

li-jia-nan commented Dec 5, 2022

feat: New Component QRCode #38948

feat: New Component QRCode #38948

Conversation

li-jia-nan commented Nov 24, 2022 • edited

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self-Check before Merge

github-actions bot commented Nov 24, 2022 • edited

github-actions bot commented Nov 24, 2022 • edited

codecov bot commented Nov 24, 2022 • edited

Codecov Report

li-jia-nan commented Nov 24, 2022

MadCcc left a comment

Choose a reason for hiding this comment

li-jia-nan commented Nov 24, 2022

MadCcc commented Nov 25, 2022

MadCcc commented Nov 25, 2022 • edited

MadCcc commented Nov 25, 2022

li-jia-nan commented Nov 25, 2022

li-jia-nan commented Nov 25, 2022 • edited

li-jia-nan commented Nov 25, 2022

li-jia-nan commented Nov 25, 2022 • edited

MadCcc commented Dec 2, 2022

li-jia-nan commented Dec 2, 2022

li-jia-nan commented Dec 5, 2022

li-jia-nan commented Nov 24, 2022 •

edited

github-actions bot commented Nov 24, 2022 •

edited

github-actions bot commented Nov 24, 2022 •

edited

codecov bot commented Nov 24, 2022 •

edited

MadCcc commented Nov 25, 2022 •

edited

li-jia-nan commented Nov 25, 2022 •

edited

li-jia-nan commented Nov 25, 2022 •

edited