Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tour): TourStepProps ButtonProps ts definition update #38939

Merged
merged 2 commits into from Nov 24, 2022

Conversation

ONLY-yours
Copy link
Contributor

@ONLY-yours ONLY-yours commented Nov 24, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English tour component stepInfo ts definition add style & classname
🇨🇳 Chinese Tour stepInfo 类型导出新增 Style 和 Classname

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022

@MadCcc
Copy link
Member

MadCcc commented Nov 24, 2022

还是 force push 一下吧,把多余的 commit 去掉

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (1c567fa) compared to base (e8875f1).
Patch has no changes to coverable lines.

❗ Current head 1c567fa differs from pull request most recent head ad2ce58. Consider uploading reports for the commit ad2ce58 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #38939   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9355      9355           
  Branches      2653      2653           
=========================================
  Hits          9355      9355           
Impacted Files Coverage Δ
components/tour/panelRender.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ONLY-yours
Copy link
Contributor Author

还是 force push 一下吧,把多余的 commit 去掉

虽然操作不熟练,但还是work了。

@MadCcc MadCcc merged commit ce5d71d into ant-design:feature Nov 24, 2022
owjs3901 pushed a commit to owjs3901/ant-design that referenced this pull request Dec 5, 2022
…n#38939)

* feat: tour ts define update

* test: add more unit test
heiyu4585 pushed a commit to heiyu4585/ant-design that referenced this pull request Dec 16, 2022
…n#38939)

* feat: tour ts define update

* test: add more unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants