Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Remove IE11 from browserslist and babel targets #38779

Merged
merged 14 commits into from Dec 25, 2022

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 21, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

babel 插件的相关改动:ant-design/antd-tools#269

应该能优化不少体积。这里是 antd/lib/alert/index.js 文件的变动:https://github.com/afc163/test-git/pull/4/files

📝 Changelog

Language Changelog
🇺🇸 English Remove IE and other legacy browsers from browserslist to reduce 10KB in bundle size.
🇨🇳 Chinese 在构建流程中去掉对 IE 等旧版本浏览器的支持以减少包体积 10KB。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022

@afc163
Copy link
Member Author

afc163 commented Nov 21, 2022

不知道为啥构建挂了。。

@github-actions

This comment was marked as outdated.

@li-jia-nan
Copy link
Member

conflict

@afc163
Copy link
Member Author

afc163 commented Dec 20, 2022

有一个问题,我们能直接用 class 么:https://caniuse.com/?search=classes

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022

size-limit report 📦

Path Size
./dist/antd.min.js 367.51 KB (-10.24 KB 🔽)
./dist/antd-with-locales.min.js 422.58 KB (-10.48 KB 🔽)

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 21, 2022

有一个问题,我们能直接用 class 么:https://caniuse.com/?search=classes

个人觉得干脆es目录直接输出module js, 那自然很多都是class的了

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 21, 2022

rc-*的 lib 引用全部换掉 es

@afc163
Copy link
Member Author

afc163 commented Dec 23, 2022

不知道为啥 CI 会挂。

图片

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3edbccb) compared to base (af012df).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38779   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          557       557           
  Lines         9625      9625           
  Branches      2722      2722           
=========================================
  Hits          9625      9625           
Impacted Files Coverage Δ
components/mentions/index.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@socket-security
Copy link

socket-security bot commented Dec 23, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Powered by socket.dev

@afc163 afc163 changed the base branch from master to feature December 24, 2022 06:37
@afc163 afc163 changed the base branch from feature to master December 24, 2022 06:38
@afc163 afc163 marked this pull request as ready for review December 24, 2022 06:39
package.json Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

zombieJ commented Dec 25, 2022

诡异,本地不报错。CI 报错

@zombieJ
Copy link
Member

zombieJ commented Dec 25, 2022

重试又好了,只能当是抽风了。 。 。

@afc163
Copy link
Member Author

afc163 commented Dec 25, 2022

不知道为啥会抽风,合并了再观察观察。

@afc163 afc163 merged commit 06bd9d1 into master Dec 25, 2022
@afc163 afc163 deleted the perf/remove-ie11-from-targets branch December 25, 2022 10:37
@afc163 afc163 mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants