Mentions data driven #38630
Merged
Mentions data driven #38630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## feature #38630 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 447 544 +97
Lines 8314 9365 +1051
Branches 2531 2652 +121
===========================================
+ Hits 8314 9365 +1051
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
afc163
reviewed
Nov 18, 2022
components/mentions/index.tsx
Outdated
| @@ -28,7 +28,7 @@ export interface OptionProps { | |||
| } | |||
|
|
|||
| export interface DataDrivenOptionProps { | |||
| label?: React.ReactNode; | |||
| label?: string | React.ReactNode; | |||
Closed
heiyu4585
force-pushed
the
Mentions-dataDriven
branch
from
cb24003
to
1ccfa74
Compare
codeball-ai-writer
bot
added
codeball:needs-review
and removed
codeball:needs-careful-review
labels
…t-design into Mentions-dataDriven
codeball-ai-writer
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
zombieJ
reviewed
Nov 21, 2022
components/mentions/index.en-US.md
Outdated
| @@ -56,6 +68,7 @@ When you need to mention someone or something. | |||
| | onResize | The callback function that is triggered when textarea resize | function({ width, height }) | - | | | |||
| | onSearch | Trigger when prefix hit | (text: string, prefix: string) => void | - | | | |||
| | onSelect | Trigger when user select the option | (option: OptionProps, prefix: string) => void | - | | | |||
| | options | Option Configuration | \[Options](#Option) | \[] | 4.25.0 | | |||
zombieJ
reviewed
Nov 21, 2022
components/mentions/index.tsx
Outdated
| return children; | ||
| }; | ||
| if (loading) { | ||
| options = [ |
There was a problem hiding this comment.
不要直接覆盖提供的参数，额外写一个 mergedOptions 来处理~
zombieJ
approved these changes
Nov 21, 2022
hengkx
reviewed
Nov 21, 2022
hengkx
reviewed
Nov 21, 2022
components/mentions/index.en-US.md
Outdated
| @@ -56,6 +68,7 @@ When you need to mention someone or something. | |||
| | onResize | The callback function that is triggered when textarea resize | function({ width, height }) | - | | | |||
| | onSearch | Trigger when prefix hit | (text: string, prefix: string) => void | - | | | |||
| | onSelect | Trigger when user select the option | (option: OptionProps, prefix: string) => void | - | | | |||
| | options | Option Configuration | \[Options](#Option) | \[] | 5.1.0 | | |||
There was a problem hiding this comment.
Suggested change
| | options | Option Configuration | \[Options](#Option) | \[] | 5.1.0 | | |
| | options | Option Configuration | [Options](#Option) | \[] | 5.1.0 | |
zombieJ
reviewed
Nov 21, 2022
|
|
||
| // =================== Warning ===================== | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| warning( |
heiyu4585
added a commit
to heiyu4585/ant-design
that referenced
this pull request
Nov 22, 2022
* feat: reset and force update * feat: update package * feat: reset * feat: update for viewer * feat: update for viewer * feat: update for viewer * feat: update for viewer * feat: update for viewer * update doc * feat: add waring * feat: update doc * feat: add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge