Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): row's 'align' and 'justify' support reponsive value #37860

Merged
merged 16 commits into from Oct 12, 2022

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Oct 5, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

row's align and justify support reponsive value,we can useage like this:

<Row align={{xs: "middle", lg: "bottom", other: "top"}}></Row>
<Row justify={{xs: "center", lg: "start", other: "end"}}></Row>

📝 Changelog

Language Changelog
🇺🇸 English row's align and justify support reponsive value
🇨🇳 Chinese Row 组件的alignjustify属性支持设置响应式的值

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (348ba4b) compared to base (3a89998).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #37860   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          444       444           
  Lines         8236      8291   +55     
  Branches      2439      2496   +57     
=========================================
+ Hits          8236      8291   +55     
Impacted Files Coverage Δ
components/alert/index.tsx 100.00% <ø> (ø)
components/avatar/index.tsx 100.00% <ø> (ø)
components/breadcrumb/BreadcrumbSeparator.tsx 100.00% <ø> (ø)
components/button/button.tsx 100.00% <ø> (ø)
components/checkbox/index.tsx 100.00% <ø> (ø)
components/config-provider/context.tsx 100.00% <ø> (ø)
components/dropdown/dropdown-button.tsx 100.00% <ø> (ø)
components/dropdown/dropdown.tsx 100.00% <ø> (ø)
components/empty/index.tsx 100.00% <ø> (ø)
components/form/FormItemInput.tsx 100.00% <ø> (ø)
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yoyo837 yoyo837 requested a review from zombieJ October 5, 2022 03:08
components/grid/row.tsx Outdated Show resolved Hide resolved
components/grid/row.tsx Outdated Show resolved Hide resolved
components/grid/row.tsx Outdated Show resolved Hide resolved
components/grid/row.tsx Outdated Show resolved Hide resolved
components/grid/row.tsx Outdated Show resolved Hide resolved
components/grid/row.tsx Outdated Show resolved Hide resolved
components/grid/row.tsx Outdated Show resolved Hide resolved
components/grid/row.tsx Outdated Show resolved Hide resolved
components/grid/row.tsx Outdated Show resolved Hide resolved
components/grid/row.tsx Outdated Show resolved Hide resolved
@kiner-tang kiner-tang requested review from afc163 and removed request for zombieJ October 9, 2022 06:08
components/grid/row.tsx Outdated Show resolved Hide resolved
components/grid/row.tsx Outdated Show resolved Hide resolved
@kiner-tang kiner-tang requested review from afc163 and removed request for afc163 October 10, 2022 06:32
@kiner-tang
Copy link
Member Author

kiner-tang commented Oct 10, 2022

有两个CI报错,看报错内容应该不是本次PR导致的
image
这边相较于之前CI测试成功的提交,仅仅只是更新了文档而已:
image

@kiner-tang kiner-tang requested review from afc163 and removed request for afc163 October 10, 2022 12:40
@afc163
Copy link
Member

afc163 commented Oct 11, 2022

看上去是这个问题 babel/babel#15031

components/grid/row.tsx Outdated Show resolved Hide resolved
@kiner-tang
Copy link
Member Author

kiner-tang commented Oct 11, 2022

image

image

这些看起来也不是这一次`PR`导致的,本地`tsc`是没问题的 @afc163

@afc163
Copy link
Member

afc163 commented Oct 11, 2022

rebase 一下 feature 吧,刚刚合并了一波大的。

@kiner-tang
Copy link
Member Author

rebase 一下 feature 吧,刚刚合并了一波大的。

好的

Co-authored-by: afc163 <afc163@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants