Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: js => ts #37375

Closed
wants to merge 0 commits into from
Closed

test: js => ts #37375

wants to merge 0 commits into from

Conversation

li-jia-nan
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

test: js => ts

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Prepare preview

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #37375 (fc2935b) into master (abbc85c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master    #37375   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          438       440    +2     
  Lines         8047      8060   +13     
  Branches      2354      2354           
=========================================
+ Hits          8047      8060   +13     
Impacted Files Coverage Δ
components/progress/Line.tsx 100.00% <100.00%> (ø)
components/upload/__tests__/mock.ts 100.00% <100.00%> (ø)
components/upload/__tests__/requests.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@li-jia-nan li-jia-nan mentioned this pull request Sep 2, 2022
19 tasks
@zongjiancai
Copy link

合并

@li-jia-nan li-jia-nan closed this Sep 3, 2022
@li-jia-nan li-jia-nan reopened this Sep 3, 2022
@li-jia-nan
Copy link
Member Author

有个很奇怪的 eslint error,不知道怎么解决,在 eslint config 里面加了 'react/no-unknown-property': 1,这个需要确认一下

@afc163
Copy link
Member

afc163 commented Sep 3, 2022

具体啥问题,截个图?

@li-jia-nan
Copy link
Member Author

具体啥问题,截个图?

9AB1890E-1381-4fc1-893D-91A35F7E90EC

找到原因了,和 #37269 这个pr有关系,把ts版本回退到 4.7.2 就可以了

@afc163
Copy link
Member

afc163 commented Sep 3, 2022

@afc163
Copy link
Member

afc163 commented Sep 3, 2022

我看作者已经修复了相关问题,本地更新一下版本?https://github.com/jsx-eslint/eslint-plugin-react/commits/master

@li-jia-nan
Copy link
Member Author

我看作者已经修复了相关问题,本地更新一下版本?https://github.com/jsx-eslint/eslint-plugin-react/commits/master

最新版 7.13.4 依然不行

@li-jia-nan
Copy link
Member Author

我看作者已经修复了相关问题,本地更新一下版本?https://github.com/jsx-eslint/eslint-plugin-react/commits/master

我把 eslint config 先还原了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants