-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(moment-to-dayjs): replace date-time lib Moment.js with Day.js #34057
Conversation
Size Change: +5.7 kB (+1%) Total Size: 896 kB
ℹ️ View Unchanged
|
是按不可变对象直接全部替换吗? |
https://ant.design/docs/react/i18n 这个文档也需要更新一下。 |
Codecov Report
@@ Coverage Diff @@
## next #34057 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 459 459
Lines 8336 8336
Branches 2391 2391
=========================================
Hits 8336 8336
Continue to review full report at Codecov.
|
package.json
Outdated
@@ -122,6 +122,7 @@ | |||
"@ctrl/tinycolor": "^3.4.0", | |||
"classnames": "^2.2.6", | |||
"copy-to-clipboard": "^3.2.0", | |||
"dayjs": "^1.11.1", | |||
"lodash": "^4.17.21", | |||
"memoize-one": "^6.0.0", | |||
"moment": "^2.29.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moment 是不是可以移动到 devDeps 里了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
ref:
#34087
#33862
Updated 23 snapshots that have different locales between moment.js and day.js, mainly because of the translation and first day of week setting. (check this commit 03cceee)
If you think the locale is incorrect in day.js, feel free to raise an issue here https://github.com/iamkun/dayjs/pulls
📝 Changelog
☑️ Self Check before Merge