Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cascader support multiple mode #31936

Merged
merged 20 commits into from
Aug 31, 2021
Merged

feat: Cascader support multiple mode #31936

merged 20 commits into from
Aug 31, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 27, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

https://preview-31936-ant-design.surge.sh/components/cascader-cn/#components-cascader-demo-multiple

📝 Changelog

Language Changelog
🇺🇸 English Cascader support multiple mode.
🇨🇳 Chinese Cascader 支持 multiple 模式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2021

Size Change: -2.03 kB (0%)

Total Size: 842 kB

Filename Size Change
./dist/antd-with-locales.min.js 347 kB -592 B (0%)
./dist/antd.compact.min.css 64.7 kB -284 B (0%)
./dist/antd.dark.min.css 66 kB -285 B (0%)
./dist/antd.min.css 64.9 kB -281 B (0%)
./dist/antd.min.js 299 kB -590 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #31936 (c1dbeae) into feature (d86e1b5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c1dbeae differs from pull request most recent head 596ff6a. Consider uploading reports for the commit 596ff6a to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #31936      +/-   ##
===========================================
- Coverage    99.96%   99.95%   -0.01%     
===========================================
  Files          409      409              
  Lines         7626     7460     -166     
  Branches      2089     2030      -59     
===========================================
- Hits          7623     7457     -166     
  Misses           3        3              
Impacted Files Coverage Δ
components/cascader/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86e1b5...596ff6a. Read the comment docs.

@zombieJ
Copy link
Member Author

zombieJ commented Aug 30, 2021

hmmm...100% 覆盖,结果覆盖率还降了……

@zombieJ zombieJ marked this pull request as ready for review August 30, 2021 17:09
@zombieJ zombieJ merged commit 282b7c8 into feature Aug 31, 2021
@zombieJ zombieJ deleted the cascader branch August 31, 2021 07:51
@zombieJ zombieJ mentioned this pull request Sep 1, 2021
15 tasks
@drizzlesconsin drizzlesconsin mentioned this pull request Sep 6, 2021
1 task
@hemengke1997
Copy link
Contributor

芜湖~

@yoyo837
Copy link
Contributor

yoyo837 commented Sep 14, 2021

芜湖~

大司马?

@hemengke1997
Copy link
Contributor

起飞!

更新了 4.17.3 配套的比如 ahooks库 中涉及到 antd 的类型还没更改,类型报错。回退了,等生态稳定了再更,嘻嘻

@tianwawawa
Copy link

error: RC_CASCARDER_SPLIT

@fenglijunnb
Copy link

fenglijunnb commented Dec 20, 2021

@zombieJ 请问一下,何时cascader 能支持和treeSelect 一样,可以自主定义选中项回填的方式呢 ,y因为确实需要cascader的样式格局,所以希望作者们能辛苦回复一下
image

@Lisa1787
Copy link

antd升级,ts定义到处报错……

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants