Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): Improve resolveOnChange method #31931

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

adaex
Copy link
Contributor

@adaex adaex commented Aug 26, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #31927

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input cannot clear content when focus it.
🇨🇳 Chinese 修复 Input focus 时点击清除图标无效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2021

@adaex
Copy link
Contributor Author

adaex commented Aug 26, 2021

It seems that my way is incorrect. I will replace it later.

@adaex adaex force-pushed the fix-input-reset branch 2 times, most recently from 53843cd to 654adda Compare August 28, 2021 08:58
@adaex adaex changed the title fix: input handleReset not work when focused Improve input resolveOnChange method Aug 28, 2021
@adaex adaex changed the title Improve input resolveOnChange method fix(input): Improve resolveOnChange method Aug 28, 2021
@adaex
Copy link
Contributor Author

adaex commented Aug 28, 2021

I think it would be better to solve the issue in this way.

@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #31931 (aa25e50) into master (5462361) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #31931   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          399       399           
  Lines         7593      7592    -1     
  Branches      2080      2080           
=========================================
- Hits          7593      7592    -1     
Impacted Files Coverage Δ
components/input/Input.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5462361...aa25e50. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Aug 28, 2021

Could you add test case?

@adaex
Copy link
Contributor Author

adaex commented Aug 28, 2021

Could you add test case?

Okay, I started to do it right away.

@adaex
Copy link
Contributor Author

adaex commented Aug 28, 2021

@afc163

I'm done. 🙇

@afc163 afc163 merged commit 01e5313 into ant-design:master Aug 30, 2021
@zombieJ zombieJ mentioned this pull request Sep 1, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input allowClear works unexpected
2 participants