New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add readonly modifier for antd table columns type #31888
feat: add readonly modifier for antd table columns type #31888
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31888 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 422 399 -23
Lines 7841 7591 -250
Branches 2276 2078 -198
==========================================
- Hits 7841 7591 -250
Continue to review full report at Codecov.
|
@zombieJ Can this be merged? |
When can this be merged? The proposing change is exactly same as the source code in |
|
ok, I' fix it tomorrow. |
338e9b9
to
dc0adc0
Compare
dc0adc0
to
681295f
Compare
@@ -44,7 +44,7 @@ describe('Table.typescript types', () => { | |||
name: string; | |||
} | |||
|
|||
const columns: ColumnProps<User>[] = [ | |||
const columns: readonly ColumnProps<User>[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new type test case instead updating old one.
Hey! Conflicting files, and it seems this is now really outdated. If this is something that still makes sense to the latest master version of antd, please send a new PR with this change :) |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
related issue: react-component/table#574
support readonly array in antd table columns type
📝 Changelog
☑️ Self Check before Merge