Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Cascader): title attributes are added to the selected content text by default #31237

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

yingpengsha
Copy link
Contributor

@yingpengsha yingpengsha commented Jul 2, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

While displayRender prop can be used for this effect, I think it should be available by default, such as in the Select component.

image

📝 Changelog

Language Changelog
🇺🇸 English Title attributes are added to the selected content text by default
🇨🇳 Chinese Cascader 组件中,默认给选中值的文本添加 title 属性

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

@yingpengsha yingpengsha changed the title [WIP]feat(Cascader): title attributes are added to the selected content text by default feat(Cascader): title attributes are added to the selected content text by default Jul 2, 2021
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #31237 (2cf832b) into feature (5d8b46c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 2cf832b differs from pull request most recent head 2cf6415. Consider uploading reports for the commit 2cf6415 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           feature    #31237      +/-   ##
============================================
+ Coverage    99.96%   100.00%   +0.03%     
============================================
  Files          397       397              
  Lines         7564      7572       +8     
  Branches      2078      2135      +57     
============================================
+ Hits          7561      7572      +11     
+ Misses           3         0       -3     
Impacted Files Coverage Δ
components/dropdown/dropdown-button.tsx 100.00% <ø> (ø)
components/cascader/index.tsx 100.00% <100.00%> (ø)
components/table/hooks/useFilter/index.tsx 100.00% <100.00%> (ø)
components/modal/index.tsx 100.00% <0.00%> (ø)
components/_util/motion.tsx 100.00% <0.00%> (ø)
components/drawer/index.tsx 100.00% <0.00%> (ø)
components/form/context.tsx 100.00% <0.00%> (ø)
components/message/index.tsx 100.00% <0.00%> (ø)
components/modal/confirm.tsx 100.00% <0.00%> (ø)
components/transfer/list.tsx 100.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8b46c...2cf6415. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jul 2, 2021

feature branch

@yingpengsha yingpengsha changed the base branch from master to feature July 2, 2021 06:23
@yingpengsha
Copy link
Contributor Author

@afc163
Done, but how can I resolve screenshots problem, I have no idea. 🤔

@afc163
Copy link
Member

afc163 commented Jul 2, 2021

Your PR mix other commits now, you should checkout branch from feature than commit your code.

@afc163 afc163 merged commit 846577b into ant-design:feature Jul 2, 2021
@yingpengsha
Copy link
Contributor Author

@afc163 When will this feature be released? I've been waiting for a month. 👀

@zombieJ zombieJ mentioned this pull request Sep 1, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants