Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table filterDropdown confirm closeDropdown #30457

Merged
merged 3 commits into from May 10, 2021
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 10, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #30454

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table call confirm({ closeDropdown: true }) in filterDropdown should not trigger onFilterDropdownVisibleChange.
🇨🇳 Chinese 修复 Table filterDropdown 调用 confirm({ closeDropdown: true }) 时也会触发 onFilterDropdownVisibleChange 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2021

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #30457 (5cf93ad) into master (b2a35f0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5cf93ad differs from pull request most recent head e77b24c. Consider uploading reports for the commit e77b24c to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30457   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7519      7520    +1     
  Branches      2048      2049    +1     
=========================================
+ Hits          7519      7520    +1     
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a35f0...e77b24c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2021

Size Change: -2 B (0%)

Total Size: 831 kB

Filename Size Change
./dist/antd-with-locales.min.js 340 kB -3 B (0%)
./dist/antd.min.js 298 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 64 kB 0 B
./dist/antd.dark.min.css 65.2 kB 0 B
./dist/antd.min.css 64 kB 0 B

compressed-size-action

@afc163 afc163 marked this pull request as ready for review May 10, 2021 07:15
@afc163 afc163 merged commit dd14752 into master May 10, 2021
@afc163 afc163 deleted the fix-table-confirm branch May 10, 2021 08:19
@afc163 afc163 mentioned this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant