Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Table expand icon style in Firefox #30410

Merged
merged 1 commit into from May 6, 2021
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 6, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #29848
close #29303
close #30408

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table broken expand icon style in Windows Firefox.
🇨🇳 Chinese 修复 Table 展开图标在 Windows Firefox 下显示异常的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

@yoyo837
Copy link
Contributor

yoyo837 commented May 6, 2021

ref: #29214

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #30410 (0bc733a) into master (387b9fd) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #30410      +/-   ##
===========================================
+ Coverage   99.97%   100.00%   +0.02%     
===========================================
  Files         398       397       -1     
  Lines        7661      7513     -148     
  Branches     2160      2103      -57     
===========================================
- Hits         7659      7513     -146     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
components/space/Item.tsx 100.00% <0.00%> (ø)
components/upload/Upload.tsx 100.00% <0.00%> (ø)
components/page-header/index.tsx 100.00% <0.00%> (ø)
components/statistic/Countdown.tsx 100.00% <0.00%> (ø)
components/upload/UploadList/ListItem.tsx 100.00% <0.00%> (ø)
components/_util/hooks/useFlexGapSupport.ts
components/space/index.tsx 100.00% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 387b9fd...0bc733a. Read the comment docs.

@afc163
Copy link
Member Author

afc163 commented May 6, 2021

检查了一下 #29214 ,去掉这行后貌似更对齐了。

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

Size Change: -22 B (0%)

Total Size: 830 kB

Filename Size Change
./dist/antd.compact.min.css 63.9 kB -7 B (0%)
./dist/antd.dark.min.css 65.2 kB -7 B (0%)
./dist/antd.min.css 63.9 kB -8 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 339 kB 0 B
./dist/antd.min.js 298 kB 0 B

compressed-size-action

@afc163 afc163 merged commit b6951f3 into master May 6, 2021
@afc163 afc163 deleted the fix-table-expand-icon branch May 6, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants