Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout-sider): menu-item width is wrong when collapsedWidth is set #30357

Conversation

Map1en
Copy link
Contributor

@Map1en Map1en commented Apr 29, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #30355

💡 Background and solution

当collapsedWidth设置时,内部menu-item的宽度是固定的,不能根据设置的宽度自适应。

📝 Changelog

Language Changelog
🇺🇸 English 修复当设置collapsedWidth时menu-item宽度错误的问题
🇨🇳 Chinese Fix the problem that menu-item width is wrong when collapsedWidth is set

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2021

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #30357 (2344937) into master (60cad5a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7523      7523           
  Branches      2105      2105           
=========================================
  Hits          7523      7523           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60cad5a...2344937. Read the comment docs.

@afc163 afc163 merged commit a39e51a into ant-design:master Apr 30, 2021
@zombieJ zombieJ mentioned this pull request Apr 30, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sider collapsedWidth not work in Menu
2 participants