Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(local): add Image preview in zh_HK and zh_TW #30100

Merged
merged 1 commit into from Apr 12, 2021

Conversation

jameslahm
Copy link
Contributor

@jameslahm jameslahm commented Apr 12, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fix #30093

💡 Background and solution

Add preview in zh_HK and zh_TW. Other locales also need to be added 🤣 .

📝 Changelog

Language Changelog
🇺🇸 English Add Image component preview text in zh_HK and zh_TW.
🇨🇳 Chinese 增加 Image 组件 preview 繁體文案。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2021

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #30100 (adc5b51) into master (aa9fac4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7519      7523    +4     
  Branches      2105      2107    +2     
=========================================
+ Hits          7519      7523    +4     
Impacted Files Coverage Δ
components/locale/zh_HK.tsx 100.00% <ø> (ø)
components/locale/zh_TW.tsx 100.00% <ø> (ø)
components/badge/index.tsx 100.00% <0.00%> (ø)
components/checkbox/Group.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9fac4...adc5b51. Read the comment docs.

@xrkffgg xrkffgg changed the title fix(local): add preview in zh_HK and zh_TW fix(local): add Image preview in zh_HK and zh_TW Apr 12, 2021
@afc163 afc163 merged commit fbb8924 into ant-design:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:Image组件在繁体下“预览”二字显示的是英文“Preview”,其它组件正常
2 participants