Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Badge): update cached isDotRef when isHidden #30090

Merged
merged 1 commit into from Apr 11, 2021

Conversation

jameslahm
Copy link
Contributor

@jameslahm jameslahm commented Apr 11, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fix #30088

💡 Background and solution

When status change to undefined or null, isDotRef does not update, which will show red dot in transition.

📝 Changelog

Language Changelog
🇺🇸 English Fix Badge toggle style when status is warning.
🇨🇳 Chinese 修复 Badge status="warning" 时切换样式异常的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2021

@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #30090 (29e9dde) into master (aa9fac4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 29e9dde differs from pull request most recent head c708f2a. Consider uploading reports for the commit c708f2a to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30090   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7519      7523    +4     
  Branches      2105      2107    +2     
=========================================
+ Hits          7519      7523    +4     
Impacted Files Coverage Δ
components/select/index.tsx 100.00% <ø> (ø)
components/badge/index.tsx 100.00% <100.00%> (ø)
components/checkbox/Group.tsx 100.00% <100.00%> (ø)
components/input/TextArea.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9fac4...c708f2a. Read the comment docs.

@afc163 afc163 merged commit d87901e into ant-design:master Apr 11, 2021
@afc163
Copy link
Member

afc163 commented Apr 22, 2021

This fix will break #30261, I revert it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hiding a status badge (e.g. warning) shows in red before hiding
2 participants