Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Descriptions labelStyle unsuccessful #29942

Merged
merged 5 commits into from Mar 30, 2021
Merged

fix: Descriptions labelStyle unsuccessful #29942

merged 5 commits into from Mar 30, 2021

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Mar 29, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #29933

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix bug that Descriptions labelStyle contentStyle unsuccessful when setting layout='vertical' bordered=true.
🇨🇳 Chinese 修复 Descriptions 设置 layout='vertical' bordered=true 时,labelStyle contentStyle 未生效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xrkffgg xrkffgg marked this pull request as draft March 29, 2021 08:38
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2021

Size Change: +10 B (0%)

Total Size: 828 kB

Filename Size Change
./dist/antd-with-locales.min.js 338 kB +8 B (0%)
./dist/antd.min.js 297 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 63.7 kB 0 B
./dist/antd.dark.min.css 65 kB 0 B
./dist/antd.min.css 63.7 kB 0 B

compressed-size-action

@xrkffgg xrkffgg marked this pull request as ready for review March 29, 2021 08:59
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #29942 (749a99a) into master (a1baecb) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 749a99a differs from pull request most recent head 8554682. Consider uploading reports for the commit 8554682 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29942   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7518      7519    +1     
  Branches      2099      2100    +1     
=========================================
+ Hits          7518      7519    +1     
Impacted Files Coverage Δ
components/descriptions/Cell.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1baecb...8554682. Read the comment docs.

@afc163 afc163 merged commit 7f15e7f into master Mar 30, 2021
@afc163 afc163 deleted the dd branch March 30, 2021 09:38
gepd pushed a commit to gepd/ant-design that referenced this pull request Apr 1, 2021
* fix: Descriptions labelStyle unsuccessful

* use hook

* Update components/descriptions/demo/style.md

* fix lint

* fix ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descriptions组件在 layout="vertical"的情况下labelStyle无效
3 participants