Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tag component close icon display bug #27226

Merged
merged 2 commits into from Oct 19, 2020
Merged

Conversation

handycode
Copy link
Contributor

@handycode handycode commented Oct 19, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#27218

💡 Background and solution

change the div tag to span tag

📝 Changelog

Language Changelog
🇺🇸 English tag component close icon display bug
🇨🇳 Chinese tag 标签自定义关闭 icon 换行 bug

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 19, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 19, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 335a836:

Sandbox Source
antd reproduction template Configuration

@handycode handycode changed the title fix: tag component close icon display bug fix: Tag component close icon display bug Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #27226 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7388      7388           
  Branches      2066      2024   -42     
=========================================
  Hits          7388      7388           
Impacted Files Coverage Δ
components/tag/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea1e52...335a836. Read the comment docs.

@afc163 afc163 merged commit fd0a513 into ant-design:master Oct 19, 2020
@zombieJ zombieJ mentioned this pull request Oct 24, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants