Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if form warp drawer, close button will trigger submit #27175

Merged
merged 2 commits into from Oct 15, 2020

Conversation

chenshuai2144
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close ant-design/pro-components#722

📝 Changelog

Language Changelog
🇺🇸 English Fix the issue that the Drawer will trigger form submission
🇨🇳 Chinese 修复 Drawer 会触发 Form submit 的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 15, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 15, 2020

@zombieJ
Copy link
Member

zombieJ commented Oct 15, 2020

CI failed

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b567c1a:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2020

Size Change: +12 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB +6 B (0%)
./dist/antd.min.js 277 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.3 kB 0 B
./dist/antd.dark.min.css 67.6 kB 0 B
./dist/antd.min.css 66.4 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #27175 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          388       388           
  Lines         7394      7394           
  Branches      2071      2071           
=========================================
  Hits          7394      7394           
Impacted Files Coverage Δ
components/drawer/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c38e68...b567c1a. Read the comment docs.

@yoyo837
Copy link
Contributor

yoyo837 commented Oct 15, 2020

#10791 一直没有type, 说明也没人放到form里 😂

@hengkx hengkx merged commit 3770b3f into master Oct 15, 2020
@hengkx hengkx deleted the chenshuai2144-patch-1 branch October 15, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DrawerForm右上角关闭会触发onFinish🐛[BUG]
5 participants