Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Dropdown icon margin style #27165

Merged
merged 1 commit into from Oct 15, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 15, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22274

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Dropdown icon missing margin.
🇨🇳 Chinese 修复 Dropdown 下拉菜单图标间距丢失的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 15, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 15, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ad2f69b:

Sandbox Source
antd reproduction template Configuration
antd-dropdown-menu-icon-styles-bug Issue #22274

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #27165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          388       388           
  Lines         7394      7394           
  Branches      2064      2071    +7     
=========================================
  Hits          7394      7394           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 771352c...ad2f69b. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +41 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd.compact.min.css 66.3 kB +15 B (0%)
./dist/antd.dark.min.css 67.6 kB +11 B (0%)
./dist/antd.min.css 66.4 kB +15 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 313 kB 0 B
./dist/antd.min.js 277 kB 0 B

compressed-size-action

@afc163 afc163 merged commit 1c38e68 into master Oct 15, 2020
@afc163 afc163 deleted the fix-dropdown-icon-margin branch October 15, 2020 06:13
@lich-yoo
Copy link
Contributor

@afc163 这个问题又改回来了
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon styles in Dropdown Menu Items are not applied if inside an anchor tag
3 participants