Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-picker): showTime should work correctly when format is function #27156

Merged
merged 1 commit into from Oct 14, 2020

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Oct 14, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #27155

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix DatePicker don't work correctly when showTime is true and format is function.
🇨🇳 Chinese 修复当 showTimetrue 并且 format 为一个函数时,DatePicker 报错问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 14, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 14, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0bc651e:

Sandbox Source
antd reproduction template Configuration
antd RangePicker showTIme with custom format Issue #27155

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #27156 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          388       388           
  Lines         7392      7394    +2     
  Branches      2070      2071    +1     
=========================================
+ Hits          7392      7394    +2     
Impacted Files Coverage Δ
components/date-picker/generatePicker/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43e2651...0bc651e. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +16 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd-with-locales.min.js 313 kB +9 B (0%)
./dist/antd.min.js 277 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.3 kB 0 B
./dist/antd.dark.min.css 67.6 kB 0 B
./dist/antd.min.css 66.3 kB 0 B

compressed-size-action

@afc163 afc163 merged commit e883e4b into master Oct 14, 2020
@afc163 afc163 deleted the fix-date-picker branch October 14, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RangePicker throws error when using showTime and a custom format function
3 participants