Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Select search bug when input chinese #26796

Merged
merged 2 commits into from Sep 17, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 17, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26790

💡 Background and solution

react-component/select#548 (comment)

📝 Changelog

Language Changelog
🇺🇸 English Fix Select compositing status lost when input first letter in Chinese.
🇨🇳 Chinese 修复 Select 搜索时输入第一个字符后中文输入法状态丢失的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 17, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 17, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6005896:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2020

Size Change: -9.78 kB (1%)

Total Size: 867 kB

Filename Size Change
./dist/antd-with-locales.min.js 350 kB -5 kB (1%)
./dist/antd.min.js 316 kB -4.78 kB (1%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.6 kB 0 B
./dist/antd.min.css 66.4 kB 0 B

compressed-size-action

@afc163 afc163 changed the title fix: Select search bug when input chinese fix: 🐛 Select search bug when input chinese Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #26796 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26796   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         384      384           
  Lines        7371     7371           
  Branches     2051     2058    +7     
=======================================
  Hits         7358     7358           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec45cb...6005896. Read the comment docs.

@afc163 afc163 merged commit dfb3279 into master Sep 17, 2020
@afc163 afc163 deleted the fix-select-search branch September 17, 2020 15:26
zombieJ pushed a commit that referenced this pull request Sep 18, 2020
* fix: Select search bug when input chinese

close #26790

* fix: test snapshot
@zombieJ zombieJ mentioned this pull request Sep 20, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select 通过 tab focus 后直接进行中文输入会忽略第一个字符
2 participants