Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): adjust type declaration for the onError of customRequest #26601

Merged
merged 2 commits into from Sep 5, 2020

Conversation

yingpengsha
Copy link
Contributor

@yingpengsha yingpengsha commented Sep 5, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26570

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the type declaration of onError in customRequest options of Upload.
🇨🇳 Chinese 修复 Upload 组件中 customRequestonError 的类型定义。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@yingpengsha yingpengsha changed the title fix(type): adjust type declaration for the onError of the Upload's customRequest fix: adjust type declaration for the onError of the Upload's customRequest Sep 5, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 5, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 5, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f1667d1:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #26601 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26601   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         383      383           
  Lines        7347     7347           
  Branches     2049     2058    +9     
=======================================
  Hits         7334     7334           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2cd6c1...f1667d1. Read the comment docs.

@kerm1it kerm1it changed the title fix: adjust type declaration for the onError of the Upload's customRequest fix(upload): adjust type declaration for the onError of customRequest Sep 5, 2020
@kerm1it kerm1it merged commit b4c0978 into ant-design:master Sep 5, 2020
@pr-triage pr-triage bot added the PR: merged label Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type declaration for the onError function of the upload component's customRequest function is incomplete.
3 participants