Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict nested table styles to only apply to direct children of td #26568

Merged
merged 1 commit into from Sep 6, 2020

Conversation

willc001
Copy link
Contributor

@willc001 willc001 commented Sep 3, 2020

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 重构
  • 功能增强
  • 国际化改进
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

  1. .ant-table-tbody > tr .ant-table-wrapper:only-child 会匹配 tr 下所有的层级,导致会意外匹配单独被包裹的表格,如:
<tr>
  <td>
    <div>some content</div>
    <div>
      <div class="ant-table-wrapper">
        ...
      </div>
    </div>
  </td>
</tr>
  1. 改为限定为匹配 td 的直接子元素

📝 更新日志怎么写?

语言 更新描述
🇺🇸 英文 Fix Table nested table styles affects all sub-level tables.
🇨🇳 中文 修复 Table 嵌套表格样式会影响所有子层级表格的问题。

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 3, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 3, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2b75a65:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #26568 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26568   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         383      383           
  Lines        7343     7343           
  Branches     2003     2045   +42     
=======================================
  Hits         7330     7330           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d28542...2b75a65. Read the comment docs.

@afc163 afc163 merged commit 79b681d into ant-design:master Sep 6, 2020
@pr-triage pr-triage bot added the PR: merged label Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants