Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip/Popover children type #26534

Merged
merged 1 commit into from Sep 2, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 2, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26517

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tooltip/Popover children tsd to accept ReactNode.
🇨🇳 Chinese 修复 Tooltip/Popover children 定义不接受 ReactNode 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 2, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 2, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b78e230:

Sandbox Source
antd reproduction template Configuration
vibrant-frost-2umwz Issue #26517

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #26534 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26534   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         383      383           
  Lines        7351     7351           
  Branches     2054     2055    +1     
=======================================
  Hits         7333     7333           
  Misses         18       18           
Impacted Files Coverage Δ
components/tooltip/index.tsx 100.00% <ø> (ø)
components/popconfirm/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88fd34...b78e230. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2020

Size Change: +19 B (0%)

Total Size: 795 kB

Filename Size Change
./dist/antd-with-locales.min.js 315 kB +9 B (0%)
./dist/antd.min.js 281 kB +10 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.1 kB 0 B
./dist/antd.dark.min.css 67.4 kB 0 B
./dist/antd.min.css 66.1 kB 0 B

compressed-size-action

@afc163 afc163 merged commit bc950d9 into master Sep 2, 2020
@afc163 afc163 deleted the fix-tooltip-children-type branch September 2, 2020 07:35
@pr-triage pr-triage bot added the PR: merged label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover would not display if content use Fragment tag
2 participants