fix: Avatar doesn't scale when display is none #26522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f2ec3a0:
|
Codecov Report
@@ Coverage Diff @@
## master #26522 +/- ##
==========================================
- Coverage 99.75% 99.75% -0.01%
==========================================
Files 383 383
Lines 7351 7343 -8
Branches 2048 2053 +5
==========================================
- Hits 7333 7325 -8
Misses 18 18
Continue to review full report at Codecov.
|
|
来个用例？ |
zombieJ
reviewed
Sep 2, 2020
| if (props.children) { | ||
| setScaleParam(); | ||
| } | ||
| }, [isImgExist]); |
There was a problem hiding this comment.
每次 effect 都算一次太耗费了，包一个 ResizeObserver 吧
|
这个测试好像不好写，display:none好像没用，我看见之前偏右大佬专门写了一个调试专用demo来测试这个问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #26521
💡 Background and solution
📝 Changelog
display: none时不会正确缩放 fallback 文字的问题。☑️ Self Check before Merge