Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 💄 fix Upload picture-card button style #26367

Merged
merged 7 commits into from Aug 24, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 24, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #26317
close #23339
close #24455
close #22386

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload picture-card style unexpected margin in Form.Item
🇨🇳 Chinese 修复 Upload 图片样式在 Form.Item 中有异常 margin 的问题(微调了 dom 结构)。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/upload/demo/picture-card.md
View rendered components/upload/demo/picture-style.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 24, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 24, 2020

@afc163 afc163 changed the title style: fix Upload picture-card button style style: 💄 fix Upload picture-card button style Aug 24, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2020

Size Change: +213 B (0%)

Total Size: 797 kB

Filename Size Change
./dist/antd-with-locales.min.js 315 kB +51 B (0%)
./dist/antd.compact.min.css 66.1 kB +26 B (0%)
./dist/antd.dark.min.css 67.4 kB +37 B (0%)
./dist/antd.min.css 66.1 kB +38 B (0%)
./dist/antd.min.js 282 kB +61 B (0%)

compressed-size-action

@afc163
Copy link
Member Author

afc163 commented Aug 24, 2020

陈年老坑,终于修掉了。

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 679cf52:

Sandbox Source
antd reproduction template Configuration
Pictures Wall - Ant Design Demo Issue #23339
dank-wave-4858k Issue #26317

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #26367 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26367   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         382      382           
  Lines        7339     7344    +5     
  Branches     2003     2055   +52     
=======================================
+ Hits         7317     7322    +5     
  Misses         22       22           
Impacted Files Coverage Δ
components/upload/Upload.tsx 100.00% <100.00%> (ø)
components/upload/UploadList.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbef76e...679cf52. Read the comment docs.

@afc163 afc163 merged commit 24a86df into master Aug 24, 2020
@afc163 afc163 deleted the fix-upload-style branch August 24, 2020 08:33
@pr-triage pr-triage bot added the PR: merged label Aug 24, 2020
@xrkffgg xrkffgg mentioned this pull request Sep 30, 2020
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment