feat: support date-fns in Picker #25822

fireairforce · 2020-07-26T17:09:04Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	Support date-fns library in Picker.
🇨🇳 Chinese	DatePicker 组件支持 date-fns 日期库。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

View rendered docs/react/replace-moment.en-US.md
View rendered docs/react/replace-moment.zh-CN.md

ant-design-bot · 2020-07-26T17:12:11Z

ant-design-bot · 2020-07-26T17:12:18Z

codesandbox-ci · 2020-07-26T17:21:45Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 808e373:

Sandbox	Source
antd reproduction template	Configuration

codecov · 2020-07-26T17:21:48Z

Codecov Report

Merging #25822 into feature will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           feature   #25822   +/-   ##
========================================
  Coverage    99.52%   99.52%           
========================================
  Files          374      374           
  Lines         7300     7300           
  Branches      2037     2037           
========================================
  Hits          7265     7265           
  Misses          35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3247772...808e373. Read the comment docs.

07akioni · 2020-07-27T02:34:08Z

docs/react/replace-moment.zh-CN.md

@@ -5,7 +5,7 @@ title: 替换 Moment.js

 ## 如何在 DatePicker 中使用自定义日期库（如 dayjs ）？

-考虑到包的大小，你可以用自定义日期库替换 Moment。在这里我们提供了两种方式来实现替换:
+考虑到包的大小，你可以用自定义日期库(目前支持 dayjs、date-fns)替换 Moment。在这里我们提供了两种方式来实现替换:


替换方式能类比么，从 datefns 导出的东西和 dayjs 一致？还有对 date-fns 的支持要加上版本提醒

嗯嗯，是类似的，都是通过 generate 的方式去生成，这里有些细节我补一下。

07akioni · 2020-07-27T02:34:14Z

docs/react/replace-moment.zh-CN.md

@@ -5,7 +5,7 @@ title: 替换 Moment.js

 ## 如何在 DatePicker 中使用自定义日期库（如 dayjs ）？

-考虑到包的大小，你可以用自定义日期库替换 Moment。在这里我们提供了两种方式来实现替换:
+考虑到包的大小，你可以用自定义日期库(目前支持 dayjs、date-fns)替换 Moment。在这里我们提供了两种方式来实现替换:


替换方式能类比么，从 datefns 导出的东西和 dayjs 一致？还有对 date-fns 的支持要加上版本提醒

fireairforce · 2020-07-27T04:06:44Z

新增了一下文档~可以CC

07akioni · 2020-07-27T04:39:45Z

docs/react/replace-moment.en-US.md

+
+### DatePicker.tsx
+
+Create `src/components/DatePicker.tsx`。


英文句号

xrkffgg · 2020-07-27T05:14:59Z

docs/react/replace-moment.en-US.md

@@ -5,7 +5,7 @@ title: Replace Moment.js

 ## How to use DatePicker with a custom date library like dayjs

-Considering it's bundle size, you might want to replace Moment.js with a different date library of your choice. We provide two ways to customize which date library is used:
+Considering it's bundle size, you might want to replace Moment.js with a different date library(now support dayjs and date-fns) of your choice. We provide two ways to customize which date library is used:


Suggested change

Considering it's bundle size, you might want to replace Moment.js with a different date library(now support dayjs and date-fns) of your choice. We provide two ways to customize which date library is used:

Considering it's bundle size, you might want to replace Moment.js with a different date library (now support dayjs and date-fns) of your choice. We provide two ways to customize which date library is used:

fireairforce · 2020-07-27T06:00:26Z

已经修改了~

fireairforce · 2020-07-27T06:15:17Z

lint看上去不是我这边的，我这边已经 rebase 到最新的了～

kerm1it · 2020-07-27T08:07:21Z

@fireairforce 这个对应的依赖已经在主分支上更新了，rc-picker@1.15.0

kerm1it · 2020-07-27T08:08:36Z

@afc163 这个直接合到master吧？

fireairforce · 2020-07-27T09:20:10Z

我用feature rebase 了一次

fireairforce · 2020-07-27T09:58:01Z

现在应该阔以了～

paxarpp · 2021-01-02T22:02:27Z

hello,
the suggested use case for date-fns does not work for ru localization,
perhaps there is some solution for localization other than the default en

Makentosh · 2021-08-19T15:27:35Z

Hello,
yes,really date-fns does not work if localization through configprovider is ru
for a long time I couldn't understand why the datepicker doesn't work

pr-triage bot added the PR: unreviewed label Jul 26, 2020

07akioni reviewed Jul 27, 2020

View reviewed changes

docs/react/replace-moment.en-US.md Outdated

### DatePicker.tsx

Create `src/components/DatePicker.tsx`。

Copy link

Contributor

07akioni Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文句号

xrkffgg reviewed Jul 27, 2020

View reviewed changes

afc163 mentioned this pull request Jul 27, 2020

docs: changelog 4.5.0 #25820

Merged

fireairforce added 5 commits July 27, 2020 17:19

feat: support in date-fns in Picker

867f279

add document

22de8c1

feat: add docs

601fe24

fix document

2fb0390

update

808e373

fireairforce force-pushed the date-fns branch from 00a58b5 to 808e373 Compare July 27, 2020 09:20

07akioni approved these changes Jul 27, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Jul 27, 2020

07akioni merged commit 1638a9c into ant-design:feature Jul 27, 2020

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Jul 27, 2020

fireairforce deleted the date-fns branch August 2, 2020 08:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support date-fns in Picker #25822

feat: support date-fns in Picker #25822

fireairforce commented Jul 26, 2020 •

edited

ant-design-bot commented Jul 26, 2020 •

edited

ant-design-bot commented Jul 26, 2020 •

edited

codesandbox-ci bot commented Jul 26, 2020 •

edited

codecov bot commented Jul 26, 2020 •

edited

07akioni Jul 27, 2020

fireairforce Jul 27, 2020

07akioni Jul 27, 2020

fireairforce commented Jul 27, 2020

07akioni Jul 27, 2020

xrkffgg Jul 27, 2020

fireairforce commented Jul 27, 2020

fireairforce commented Jul 27, 2020

kerm1it commented Jul 27, 2020

kerm1it commented Jul 27, 2020

fireairforce commented Jul 27, 2020

fireairforce commented Jul 27, 2020

paxarpp commented Jan 2, 2021 •

edited

Makentosh commented Aug 19, 2021

	Considering it's bundle size, you might want to replace Moment.js with a different date library(now support dayjs and date-fns) of your choice. We provide two ways to customize which date library is used:
	Considering it's bundle size, you might want to replace Moment.js with a different date library (now support dayjs and date-fns) of your choice. We provide two ways to customize which date library is used:

feat: support date-fns in Picker #25822

feat: support date-fns in Picker #25822

Conversation

fireairforce commented Jul 26, 2020 • edited

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

ant-design-bot commented Jul 26, 2020 • edited

ant-design-bot commented Jul 26, 2020 • edited

codesandbox-ci bot commented Jul 26, 2020 • edited

codecov bot commented Jul 26, 2020 • edited

Codecov Report

07akioni Jul 27, 2020

Choose a reason for hiding this comment

fireairforce Jul 27, 2020

Choose a reason for hiding this comment

07akioni Jul 27, 2020

Choose a reason for hiding this comment

fireairforce commented Jul 27, 2020

07akioni Jul 27, 2020

Choose a reason for hiding this comment

xrkffgg Jul 27, 2020

Choose a reason for hiding this comment

fireairforce commented Jul 27, 2020

fireairforce commented Jul 27, 2020

kerm1it commented Jul 27, 2020

kerm1it commented Jul 27, 2020

fireairforce commented Jul 27, 2020

fireairforce commented Jul 27, 2020

paxarpp commented Jan 2, 2021 • edited

Makentosh commented Aug 19, 2021

fireairforce commented Jul 26, 2020 •

edited

ant-design-bot commented Jul 26, 2020 •

edited

ant-design-bot commented Jul 26, 2020 •

edited

codesandbox-ci bot commented Jul 26, 2020 •

edited

codecov bot commented Jul 26, 2020 •

edited

paxarpp commented Jan 2, 2021 •

edited