Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TreeSelect treeNodeLabelProp should only work on values #25755

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 22, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #23079

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix TreeSelect treeNodeLabelProp affect tree node render result.
🇨🇳 Chinese 修复 TreeSelect treeNodeLabelProp 会影响树节点展示内容的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 22, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 22, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ba2b280:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #25755 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25755   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         369      369           
  Lines        7197     7197           
  Branches     1966     2014   +48     
=======================================
  Hits         7162     7162           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd9f1e...ba2b280. Read the comment docs.

@zombieJ zombieJ merged commit f9136b2 into master Jul 22, 2020
@zombieJ zombieJ deleted the fix-tree-select branch July 22, 2020 13:18
@@ -141,7 +141,7 @@
"rc-textarea": "~0.3.0",
"rc-tooltip": "~4.2.0",
"rc-tree": "~3.6.0",
"rc-tree-select": "~4.0.2",
"rc-tree-select": "~4.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle size 提高了 9KB,排查一下重复依赖。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rc-tree 的版本问题,在 feature branch 已经提上来了。下个 minor 就好了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeSelect的title与treeNodeLabelProp
3 participants