Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Carousel findDOMNode warning #25744

Merged
merged 1 commit into from
Jul 22, 2020
Merged

fix: Carousel findDOMNode warning #25744

merged 1 commit into from
Jul 22, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 22, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

akiran/react-slick#1442

#22477

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Carousel findDOMNode warning in strict mode.
🇨🇳 Chinese 修复 Carousel 在 React 严格模式下的 findDOMNode 废弃警告。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 22, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 22, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1613925:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #25744 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25744   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         369      369           
  Lines        7197     7197           
  Branches     2014     1966   -48     
=======================================
  Hits         7162     7162           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f3ea7...1613925. Read the comment docs.

@xrkffgg xrkffgg merged commit 1cd9f1e into master Jul 22, 2020
@xrkffgg xrkffgg deleted the up-react-slick branch July 22, 2020 06:23
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants