Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Form control clear icon position #25728

Merged
merged 2 commits into from
Jul 21, 2020
Merged

fix: Form control clear icon position #25728

merged 2 commits into from
Jul 21, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 21, 2020 •
edited by markdownify bot

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23430

💡 Background and solution

wrong ❌ correct ✅
image image

📝 Changelog

Language Changelog
🇺🇸 English Fix Select clear icon position in Form.Item.
🇨🇳 Chinese 修复 Select 清除按钮在 Form.Item 下位置不对的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/demo/validate-static.md

@afc163 afc163 requested a review from 07akioni July 21, 2020 07:55
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 21, 2020 •
edited

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 21, 2020 •
edited

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b5dc914:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 merged commit 5ac3313 into master Jul 21, 2020
@afc163 afc163 deleted the fix-form-validation-style branch July 21, 2020 08:18
@07akioni 07akioni mentioned this pull request Jul 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@07akioni 07akioni Awaiting requested review from 07akioni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form.Item hasFeedback validateStatus covers the select component's allowClear
2 participants
@afc163 @ant-design-bot