fix: Calendar validRange prevents disabledDate #25626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 982d9ce:
|
|
CI 报错 react-intl 没安装？ |
xrkffgg
reviewed
Jul 15, 2020
| : false; | ||
| return inRange || !!disabledDate?.(date); | ||
| }, | ||
| [disabledDate, validRange], |
|
changelog 填写一下，CI 先不用管 |
|
这个 issue 是说少了一个选项，这个变动看起来只是重构了 disabledDate 逻辑。没有修复 month select 少选项的问题 |
zombieJ
reviewed
Jul 16, 2020
| @@ -110,7 +110,7 @@ function MonthSelect<DateType>(props: SharedProps<DateType>) { | |||
|
|
|||
| const months = locale.shortMonths || generateConfig.locale.getShortMonths!(locale.locale); | |||
| const options: { label: string; value: number }[] = []; | |||
| for (let index = start; index < end; index += 1) { | |||
| for (let index = start; index <= end; index += 1) { | |||
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
close #25382
close #25633
close #25606
💡 Background and solution
📝 Changelog
Fix Calendar month select display
修复 Calendar 组件 MonthSelect 月份下拉筛选
☑️ Self Check before Merge