Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: 📦 remove babel-runtime and enable @babel/runtime #25530

Merged
merged 2 commits into from Jul 9, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 9, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#22698

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Remove babel-runtime and add @babel/runtime in dependencies, reduce gzipped bundle size 18.6KB.
🇨🇳 Chinese 移除 babel-runtime 并添加 @babel/runtime 依赖,减少 gzipped 包体积 18.6KB

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title perf: 🗑️ remove babel-runtime from deps perf: 🗑️ Remove babel-runtime from deps Jul 9, 2020
@afc163 afc163 changed the title perf: 🗑️ Remove babel-runtime from deps chore: 🗑️ Remove babel-runtime from deps Jul 9, 2020
@afc163 afc163 changed the title chore: 🗑️ Remove babel-runtime from deps chore: 🗑️ remove babel-runtime from deps Jul 9, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 9, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 9, 2020

@afc163 afc163 changed the title chore: 🗑️ remove babel-runtime from deps chore: remove babel-runtime from deps Jul 9, 2020
@afc163 afc163 changed the title chore: remove babel-runtime from deps perf: 🚮 remove babel-runtime from deps Jul 9, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@afc163
Copy link
Member Author

afc163 commented Jul 9, 2020

少了 6KB ....

- 293.9KB
+ 287.9KB

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #25530 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25530   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         368      368           
  Lines        7205     7205           
  Branches     2011     2011           
=======================================
  Hits         7170     7170           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f507a21...d302547. Read the comment docs.

@afc163 afc163 changed the title perf: 🚮 remove babel-runtime from deps perf: 📦 remove babel-runtime and enable @babel/runtime Jul 9, 2020
@afc163 afc163 merged commit 5ce2b62 into master Jul 9, 2020
@afc163 afc163 deleted the remove-babel-runtime branch July 9, 2020 05:56
@zombieJ
Copy link
Member

zombieJ commented Jul 9, 2020

真是一大笔巨款 😼

@yoyo837
Copy link
Contributor

yoyo837 commented Jul 9, 2020

是不是可以把CI的bundle size要求改小?

@afc163
Copy link
Member Author

afc163 commented Jul 9, 2020

先不动吧,20KB 挥霍起来很快。什么时候改到 200KB 以下再改 limit。

@zombieJ zombieJ mentioned this pull request Jul 11, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants