Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix wrong event type of AntTreeNodeMouseEvent #21200

Merged
merged 1 commit into from Feb 3, 2020

Conversation

jirkalhotka
Copy link
Contributor

@jirkalhotka jirkalhotka commented Feb 3, 2020

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

#21102 fixed this in 4.x.x, now adding a fix for 3.x.x

πŸ’‘ Background and solution

This fixes #16618 – the fix suggested in the issue which was implemented is wrong, the event type is actually a React.DragEvent

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English
πŸ‡¨πŸ‡³ Chinese

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aeb9f6b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #21200 into 3.x-stable will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.x-stable   #21200   +/-   ##
===========================================
  Coverage       97.82%   97.82%           
===========================================
  Files             286      286           
  Lines            7754     7754           
  Branches         2185     2188    +3     
===========================================
  Hits             7585     7585           
  Misses            169      169
Impacted Files Coverage Ξ”
components/tree/Tree.tsx 96.66% <ΓΈ> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 59c29a4...aeb9f6b. Read the comment docs.

@afc163 afc163 merged commit 3fb7325 into ant-design:3.x-stable Feb 3, 2020
@jirkalhotka jirkalhotka deleted the patch-1 branch February 3, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants